Phases 3 & 4: Complete data access architecture migration
Phase 3 — eliminated ApplicationDbContext from all non-exempt controllers, routing all data access through IUnitOfWork. Added IPlainRepository<T> for the four platform entities (Announcement, BannedIp, DashboardTip, ReleaseNote) that intentionally don't extend BaseEntity and therefore can't use the constrained IRepository<T>. Added permanent-exception comments to the 18 controllers that legitimately retain direct DbContext access (Identity infra, cross-tenant platform ops, bulk streaming exports). Phase 4 — added EnforceDataAccessArchitecture() to Program.cs, a startup gate that reflects over every Controller subclass and throws at boot if any non-exempt controller injects ApplicationDbContext. The app cannot start with a violation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -1,9 +1,7 @@
|
||||
using Microsoft.AspNetCore.Authorization;
|
||||
using PowderCoating.Shared.Constants;
|
||||
using Microsoft.AspNetCore.Mvc;
|
||||
using Microsoft.EntityFrameworkCore;
|
||||
using PowderCoating.Core.Interfaces;
|
||||
using PowderCoating.Infrastructure.Data;
|
||||
using System.IO.Compression;
|
||||
using System.Text;
|
||||
|
||||
@@ -12,14 +10,14 @@ namespace PowderCoating.Web.Controllers;
|
||||
[Authorize(Policy = AppConstants.Policies.CanManageJobs)]
|
||||
public class AccountingExportController : Controller
|
||||
{
|
||||
private readonly ApplicationDbContext _context;
|
||||
private readonly IUnitOfWork _unitOfWork;
|
||||
private readonly ITenantContext _tenantContext;
|
||||
private readonly PowderCoating.Application.Interfaces.IAuditService _auditService;
|
||||
|
||||
public AccountingExportController(ApplicationDbContext context, ITenantContext tenantContext,
|
||||
public AccountingExportController(IUnitOfWork unitOfWork, ITenantContext tenantContext,
|
||||
PowderCoating.Application.Interfaces.IAuditService auditService)
|
||||
{
|
||||
_context = context;
|
||||
_unitOfWork = unitOfWork;
|
||||
_tenantContext = tenantContext;
|
||||
_auditService = auditService;
|
||||
}
|
||||
@@ -60,42 +58,33 @@ public class AccountingExportController : Controller
|
||||
[ValidateAntiForgeryToken]
|
||||
public async Task<IActionResult> Export(DateTime startDate, DateTime endDate, string format)
|
||||
{
|
||||
var companyId = _tenantContext.GetCurrentCompanyId() ?? 0;
|
||||
var start = startDate.Date;
|
||||
var end = endDate.Date.AddDays(1).AddTicks(-1);
|
||||
|
||||
// ── Load data ─────────────────────────────────────────────────────────
|
||||
var invoices = await _context.Invoices
|
||||
.Include(i => i.InvoiceItems)
|
||||
.Include(i => i.Payments)
|
||||
.Include(i => i.Customer)
|
||||
.Where(i => !i.IsDeleted && i.CompanyId == companyId
|
||||
&& i.InvoiceDate >= start && i.InvoiceDate <= end)
|
||||
var invoices = (await _unitOfWork.Invoices.FindAsync(
|
||||
i => i.InvoiceDate >= start && i.InvoiceDate <= end,
|
||||
false,
|
||||
i => i.InvoiceItems,
|
||||
i => i.Payments,
|
||||
i => i.Customer))
|
||||
.OrderBy(i => i.InvoiceDate)
|
||||
.ToListAsync();
|
||||
.ToList();
|
||||
|
||||
var expenses = await _context.Set<PowderCoating.Core.Entities.Expense>()
|
||||
.Include(e => e.Vendor)
|
||||
.Include(e => e.ExpenseAccount)
|
||||
.Include(e => e.PaymentAccount)
|
||||
.Where(e => !e.IsDeleted && e.CompanyId == companyId
|
||||
&& e.Date >= start && e.Date <= end)
|
||||
var expenses = (await _unitOfWork.Expenses.FindAsync(
|
||||
e => e.Date >= start && e.Date <= end,
|
||||
false,
|
||||
e => e.Vendor,
|
||||
e => e.ExpenseAccount,
|
||||
e => e.PaymentAccount))
|
||||
.OrderBy(e => e.Date)
|
||||
.ToListAsync();
|
||||
.ToList();
|
||||
|
||||
var bills = await _context.Set<PowderCoating.Core.Entities.Bill>()
|
||||
.Include(b => b.Vendor)
|
||||
.Include(b => b.LineItems).ThenInclude(l => l.Account)
|
||||
.Include(b => b.Payments)
|
||||
.Where(b => !b.IsDeleted && b.CompanyId == companyId
|
||||
&& b.BillDate >= start && b.BillDate <= end)
|
||||
.OrderBy(b => b.BillDate)
|
||||
.ToListAsync();
|
||||
var bills = await _unitOfWork.Bills.GetForDateRangeAsync(start, end);
|
||||
|
||||
var customers = await _context.Customers
|
||||
.Where(c => !c.IsDeleted && c.CompanyId == companyId)
|
||||
var customers = (await _unitOfWork.Customers.GetAllAsync())
|
||||
.OrderBy(c => c.CompanyName ?? c.ContactFirstName)
|
||||
.ToListAsync();
|
||||
.ToList();
|
||||
|
||||
// ── Build ZIP ─────────────────────────────────────────────────────────
|
||||
using var ms = new MemoryStream();
|
||||
|
||||
Reference in New Issue
Block a user