Phases 3 & 4: Complete data access architecture migration
Phase 3 — eliminated ApplicationDbContext from all non-exempt controllers, routing all data access through IUnitOfWork. Added IPlainRepository<T> for the four platform entities (Announcement, BannedIp, DashboardTip, ReleaseNote) that intentionally don't extend BaseEntity and therefore can't use the constrained IRepository<T>. Added permanent-exception comments to the 18 controllers that legitimately retain direct DbContext access (Identity infra, cross-tenant platform ops, bulk streaming exports). Phase 4 — added EnforceDataAccessArchitecture() to Program.cs, a startup gate that reflects over every Controller subclass and throws at boot if any non-exempt controller injects ApplicationDbContext. The app cannot start with a violation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -1,7 +1,6 @@
|
||||
using Microsoft.AspNetCore.Authorization;
|
||||
using Microsoft.AspNetCore.Mvc;
|
||||
using Microsoft.EntityFrameworkCore;
|
||||
using PowderCoating.Infrastructure.Data;
|
||||
using PowderCoating.Core.Interfaces;
|
||||
using PowderCoating.Shared.Constants;
|
||||
using System.Text;
|
||||
|
||||
@@ -15,12 +14,12 @@ namespace PowderCoating.Web.Controllers;
|
||||
[Authorize(Policy = AppConstants.Policies.CompanyAdminOnly)]
|
||||
public class SmsConsentAuditController : Controller
|
||||
{
|
||||
private readonly ApplicationDbContext _context;
|
||||
private readonly IUnitOfWork _unitOfWork;
|
||||
private readonly ILogger<SmsConsentAuditController> _logger;
|
||||
|
||||
public SmsConsentAuditController(ApplicationDbContext context, ILogger<SmsConsentAuditController> logger)
|
||||
public SmsConsentAuditController(IUnitOfWork unitOfWork, ILogger<SmsConsentAuditController> logger)
|
||||
{
|
||||
_context = context;
|
||||
_unitOfWork = unitOfWork;
|
||||
_logger = logger;
|
||||
}
|
||||
|
||||
@@ -31,14 +30,12 @@ public class SmsConsentAuditController : Controller
|
||||
{
|
||||
try
|
||||
{
|
||||
var query = _context.Customers
|
||||
.AsNoTracking()
|
||||
.Where(c => !c.IsDeleted);
|
||||
var allCustomers = await _unitOfWork.Customers.GetAllAsync();
|
||||
|
||||
if (!string.IsNullOrWhiteSpace(search))
|
||||
{
|
||||
var s = search.Trim().ToLower();
|
||||
query = query.Where(c =>
|
||||
allCustomers = allCustomers.Where(c =>
|
||||
(c.ContactFirstName != null && c.ContactFirstName.ToLower().Contains(s)) ||
|
||||
(c.ContactLastName != null && c.ContactLastName.ToLower().Contains(s)) ||
|
||||
(c.CompanyName != null && c.CompanyName.ToLower().Contains(s)) ||
|
||||
@@ -46,43 +43,25 @@ public class SmsConsentAuditController : Controller
|
||||
(c.Phone != null && c.Phone.Contains(s)));
|
||||
}
|
||||
|
||||
var customers = await query
|
||||
.Select(c => new
|
||||
{
|
||||
c.Id,
|
||||
c.CompanyName,
|
||||
c.ContactFirstName,
|
||||
c.ContactLastName,
|
||||
c.IsCommercial,
|
||||
c.Phone,
|
||||
c.MobilePhone,
|
||||
c.NotifyBySms,
|
||||
c.SmsConsentedAt,
|
||||
c.SmsConsentMethod,
|
||||
c.SmsOptedOutAt
|
||||
})
|
||||
var allRows = allCustomers
|
||||
.OrderBy(c => c.CompanyName ?? c.ContactLastName ?? c.ContactFirstName)
|
||||
.ToListAsync();
|
||||
.Select(c => new SmsConsentRow
|
||||
{
|
||||
CustomerId = c.Id,
|
||||
CustomerName = GetDisplayName(c.IsCommercial, c.CompanyName, c.ContactFirstName, c.ContactLastName),
|
||||
Phone = c.Phone,
|
||||
MobilePhone = c.MobilePhone,
|
||||
NotifyBySms = c.NotifyBySms,
|
||||
ConsentedAt = c.SmsConsentedAt,
|
||||
ConsentMethod = c.SmsConsentMethod,
|
||||
OptedOutAt = c.SmsOptedOutAt,
|
||||
SmsStatus = ResolveSmsStatus(c.NotifyBySms, c.SmsConsentedAt, c.SmsOptedOutAt)
|
||||
}).ToList();
|
||||
|
||||
var allRows = customers.Select(c => new SmsConsentRow
|
||||
{
|
||||
CustomerId = c.Id,
|
||||
CustomerName = GetDisplayName(c.IsCommercial, c.CompanyName, c.ContactFirstName, c.ContactLastName),
|
||||
Phone = c.Phone,
|
||||
MobilePhone = c.MobilePhone,
|
||||
NotifyBySms = c.NotifyBySms,
|
||||
ConsentedAt = c.SmsConsentedAt,
|
||||
ConsentMethod = c.SmsConsentMethod,
|
||||
OptedOutAt = c.SmsOptedOutAt,
|
||||
SmsStatus = ResolveSmsStatus(c.NotifyBySms, c.SmsConsentedAt, c.SmsOptedOutAt)
|
||||
}).ToList();
|
||||
var optedIn = allRows.Count(r => r.SmsStatus == "active");
|
||||
var optedOut = allRows.Count(r => r.SmsStatus == "opted-out");
|
||||
var never = allRows.Count(r => r.SmsStatus == "never");
|
||||
|
||||
// Stat counts across unfiltered set
|
||||
var optedIn = allRows.Count(r => r.SmsStatus == "active");
|
||||
var optedOut = allRows.Count(r => r.SmsStatus == "opted-out");
|
||||
var never = allRows.Count(r => r.SmsStatus == "never");
|
||||
|
||||
// Apply filter
|
||||
var filtered = filter switch
|
||||
{
|
||||
"opted-in" => allRows.Where(r => r.SmsStatus == "active").ToList(),
|
||||
@@ -119,25 +98,9 @@ public class SmsConsentAuditController : Controller
|
||||
{
|
||||
try
|
||||
{
|
||||
var customers = await _context.Customers
|
||||
.AsNoTracking()
|
||||
.Where(c => !c.IsDeleted)
|
||||
.Select(c => new
|
||||
{
|
||||
c.Id,
|
||||
c.CompanyName,
|
||||
c.ContactFirstName,
|
||||
c.ContactLastName,
|
||||
c.IsCommercial,
|
||||
c.Phone,
|
||||
c.MobilePhone,
|
||||
c.NotifyBySms,
|
||||
c.SmsConsentedAt,
|
||||
c.SmsConsentMethod,
|
||||
c.SmsOptedOutAt
|
||||
})
|
||||
var customers = (await _unitOfWork.Customers.GetAllAsync())
|
||||
.OrderBy(c => c.CompanyName ?? c.ContactLastName ?? c.ContactFirstName)
|
||||
.ToListAsync();
|
||||
.ToList();
|
||||
|
||||
var sb = new StringBuilder();
|
||||
sb.AppendLine("Customer Name,Phone,Mobile Phone,SMS Status,Consented At (UTC),Consent Method,Opted Out At (UTC)");
|
||||
|
||||
Reference in New Issue
Block a user