Payment hardening: InvariantCulture on JS literals, remove dead CustomerEmail
Razor numeric expressions emitted into JS literals (MAX_TOTAL, SURCHARGE_VALUE) now use InvariantCulture, matching the pattern already used on the deposit page. Without this, a server culture with comma decimal separators would silently truncate values like 2.5% to 2. CustomerEmail removed from PaymentPageViewModel and DepositPaymentPageViewModel — it was populated from the DB on every payment page load but never consumed after receipt_email was removed from the Stripe PaymentIntent. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -75,7 +75,6 @@ public class PaymentController : Controller
|
||||
CustomerName = customer != null
|
||||
? $"{customer.ContactFirstName} {customer.ContactLastName}".Trim()
|
||||
: "Valued Customer",
|
||||
CustomerEmail = customer?.Email ?? string.Empty,
|
||||
CompanyName = company!.CompanyName,
|
||||
BalanceDue = invoice.BalanceDue,
|
||||
InvoiceTotal = invoice.Total,
|
||||
@@ -258,7 +257,6 @@ public class PaymentController : Controller
|
||||
CustomerName = customer != null
|
||||
? $"{customer.ContactFirstName} {customer.ContactLastName}".Trim()
|
||||
: quote.ProspectContactName ?? "Valued Customer",
|
||||
CustomerEmail = customer?.Email ?? quote.ProspectEmail ?? string.Empty,
|
||||
CompanyName = company!.CompanyName,
|
||||
DepositAmount = depositAmount,
|
||||
QuoteTotal = quote.Total,
|
||||
@@ -937,7 +935,6 @@ public class PaymentPageViewModel
|
||||
public int InvoiceId { get; set; }
|
||||
public string Token { get; set; } = string.Empty;
|
||||
public string CustomerName { get; set; } = string.Empty;
|
||||
public string CustomerEmail { get; set; } = string.Empty;
|
||||
public string CompanyName { get; set; } = string.Empty;
|
||||
public decimal BalanceDue { get; set; }
|
||||
public decimal InvoiceTotal { get; set; }
|
||||
@@ -958,7 +955,6 @@ public class DepositPaymentPageViewModel
|
||||
public int QuoteId { get; set; }
|
||||
public string Token { get; set; } = string.Empty;
|
||||
public string CustomerName { get; set; } = string.Empty;
|
||||
public string CustomerEmail { get; set; } = string.Empty;
|
||||
public string CompanyName { get; set; } = string.Empty;
|
||||
public decimal DepositAmount { get; set; }
|
||||
public decimal QuoteTotal { get; set; }
|
||||
|
||||
Reference in New Issue
Block a user