spouliot/PowderCoatingLogix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix failing test: revert quote-based discount to use sourceQuote.DiscountAmount

Browse Source 
The quote discount must come from the agreed quote price, not the job's pricing
snapshot (which may have DiscountAmount=0 for legacy or unset reasons). The job
snapshot fix only applies to direct jobs where no source quote exists.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Scott Pouliot
2026-05-16 11:29:12 -04:00
parent 3a1928f9bf
commit b2d6fae400
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/PowderCoating.Web/Controllers/InvoicesController.cs
+3 -4
View File
@@ -469,11 +469,10 @@ public class InvoicesController : Controller
}); });
} }
// Use the quote's agreed tax rate. For discount, prefer the job's current pricing // Use the quote's agreed tax rate and discount — these represent the customer-approved
// snapshot — it is recalculated on every save and captures any post-conversion edits. // price and must not be recomputed from the job's current state.
// Fall back to the original quote discount only if no snapshot exists.
dto.TaxPercent = sourceQuote.TaxPercent; dto.TaxPercent = sourceQuote.TaxPercent;
dto.DiscountAmount = jobBreakdown?.DiscountAmount ?? sourceQuote.DiscountAmount; dto.DiscountAmount = sourceQuote.DiscountAmount;
} }
else if (hadJobItems) else if (hadJobItems)
{ {