Fix subscription expiry logic and HTML entities in page titles

Subscription expiry (SubscriptionExpiryBackgroundService):
- Trials with no grace period now go directly Active -> Expired instead
  of briefly entering GracePeriod for a day, which was causing repeated
  'Grace Period Started' admin notification emails
- Remove redundant isTrial variable (query already filters to non-Stripe
  companies, so all processed companies are trials by definition)
- Save per-company inside the loop so a single SaveChangesAsync failure
  no longer discards all other companies' status changes and notification
  log entries (which was the other cause of repeated emails)

HTML entities in page titles (33 views):
- Replace – / — with plain ' - ' in ViewData["Title"] C#
  strings; Razor HTML-encodes these when rendering @ViewData["Title"],
  causing browsers to display the literal text '–' instead of a dash

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

src/PowderCoating.Web/Views/Accounts/Ledger.cshtml

@@ -1,8 +1,8 @@
-@model PowderCoating.Application.DTOs.Accounting.AccountLedgerDto
+@model PowderCoating.Application.DTOs.Accounting.AccountLedgerDto
 @using PowderCoating.Core.Enums
 
 @{
-    ViewData["Title"] = $"Ledger — {Model.AccountNumber} {Model.Name}";
+    ViewData["Title"] = $"Ledger - {Model.AccountNumber} {Model.Name}";
     ViewData["PageIcon"] = "bi-journal-text";
     ViewData["PageHelpTitle"] = "Account Ledger";
     ViewData["PageHelpContent"] = "A chronological list of every transaction posted to this account. Click any Reference to open the source record. Debit increases asset and expense accounts; credit increases liability, equity, and revenue accounts. Use the date range or quick buttons (This Month, YTD, etc.) to narrow the view.";

src/PowderCoating.Web/Views/BankReconciliations/Report.cshtml

@@ -1,7 +1,7 @@
-@model PowderCoating.Core.Entities.BankReconciliation
+@model PowderCoating.Core.Entities.BankReconciliation
 @using PowderCoating.Web.Controllers
 @{
-    ViewData["Title"] = $"Reconciliation Report – {Model.Account?.Name}";
+    ViewData["Title"] = $"Reconciliation Report - {Model.Account?.Name}";
     var clearedDeposits = ViewBag.ClearedDeposits as IEnumerable<PowderCoating.Core.Entities.Payment> ?? Enumerable.Empty<PowderCoating.Core.Entities.Payment>();
     var clearedPayments = ViewBag.ClearedPayments as List<ReconciliationItem> ?? new();
 }

src/PowderCoating.Web/Views/Budgets/Edit.cshtml

@@ -1,8 +1,8 @@
-@using PowderCoating.Web.Controllers
+@using PowderCoating.Web.Controllers
 @model BudgetCreateVm
 
 @{
-    ViewData["Title"] = $"Edit Budget — {Model.Name}";
+    ViewData["Title"] = $"Edit Budget - {Model.Name}";
     ViewData["PageIcon"] = "bi-pencil";
     var months = new[] { "Jan", "Feb", "Mar", "Apr", "May", "Jun", "Jul", "Aug", "Sep", "Oct", "Nov", "Dec" };
 }

src/PowderCoating.Web/Views/CompanySettings/EditTemplate.cshtml

@@ -1,6 +1,6 @@
-@model PowderCoating.Application.DTOs.Notification.NotificationTemplateDto
+@model PowderCoating.Application.DTOs.Notification.NotificationTemplateDto
 @{
-    ViewData["Title"] = $"Edit Template — {Model.DisplayName}";
+    ViewData["Title"] = $"Edit Template - {Model.DisplayName}";
     ViewData["PageIcon"] = "bi-envelope-gear";
     var placeholders = ViewBag.Placeholders as List<(string Placeholder, string Description)>
         ?? new List<(string, string)>();

src/PowderCoating.Web/Views/Customers/Statement.cshtml

@@ -1,6 +1,6 @@
-@model PowderCoating.Application.DTOs.Accounting.CustomerStatementDto
+@model PowderCoating.Application.DTOs.Accounting.CustomerStatementDto
 @{
-    ViewData["Title"] = $"Statement – {Model.CustomerName}";
+    ViewData["Title"] = $"Statement - {Model.CustomerName}";
 }
 
 <div class="d-flex justify-content-between align-items-start mb-4 flex-wrap gap-2">

src/PowderCoating.Web/Views/Help/CustomFormulaTemplates.cshtml

@@ -1,5 +1,5 @@
-@{
-    ViewData["Title"] = "Custom Formula Item Templates — Help";
+@{
+    ViewData["Title"] = "Custom Formula Item Templates - Help";
 }
 
 <div class="row g-4">

src/PowderCoating.Web/Views/Inventory/Label.cshtml

@@ -1,6 +1,6 @@
-@model PowderCoating.Application.DTOs.Inventory.InventoryItemDto
+@model PowderCoating.Application.DTOs.Inventory.InventoryItemDto
 @{
-    ViewData["Title"] = $"Label — {Model.Name}";
+    ViewData["Title"] = $"Label - {Model.Name}";
     Layout = null; // standalone print page
 }
 <!DOCTYPE html>

src/PowderCoating.Web/Views/Inventory/Scan.cshtml

@@ -1,4 +1,4 @@
-@using PowderCoating.Application.DTOs.Inventory
+@using PowderCoating.Application.DTOs.Inventory
 @using PowderCoating.Web.Controllers
 @{
     var item = ViewBag.ItemDto as InventoryItemDto;
@@ -6,7 +6,7 @@
     var otherJobs = ViewBag.OtherJobs as List<ScanJobOption> ?? new();
     var preselectedJobId = ViewBag.PreselectedJobId as int?;
     var scanError = ViewBag.ScanError as string;
-    ViewData["Title"] = $"Log Usage &mdash; {item?.Name}";
+    ViewData["Title"] = $"Log Usage - {item?.Name}";
     Layout = null; // mobile-first standalone page
 }
 <!DOCTYPE html>

src/PowderCoating.Web/Views/Jobs/EditItems.cshtml

@@ -1,8 +1,8 @@
-@model PowderCoating.Application.DTOs.Job.JobEditItemsViewModel
+@model PowderCoating.Application.DTOs.Job.JobEditItemsViewModel
 @using PowderCoating.Core.Entities
 
 @{
-    ViewData["Title"] = $"Edit Items — {Model.JobNumber}";
+    ViewData["Title"] = $"Edit Items - {Model.JobNumber}";
     ViewData["PageIcon"] = "bi-list-check";
 }
 

src/PowderCoating.Web/Views/Jobs/Intake.cshtml

@@ -1,7 +1,7 @@
-@model (PowderCoating.Application.DTOs.Job.JobDto Job, PowderCoating.Application.DTOs.Job.IntakeJobDto Form)
+@model (PowderCoating.Application.DTOs.Job.JobDto Job, PowderCoating.Application.DTOs.Job.IntakeJobDto Form)
 
 @{
-    ViewData["Title"] = $"Part Intake — {Model.Job.JobNumber}";
+    ViewData["Title"] = $"Part Intake - {Model.Job.JobNumber}";
     ViewData["PageIcon"] = "bi-box-seam";
     var job = Model.Job;
     var form = Model.Form;

src/PowderCoating.Web/Views/PurchaseOrders/Receive.cshtml

@@ -1,8 +1,8 @@
-@using PowderCoating.Application.DTOs.PurchaseOrder
+@using PowderCoating.Application.DTOs.PurchaseOrder
 @model ReceivePurchaseOrderDto
 
 @{
-    ViewData["Title"] = $"Receive Goods — {ViewBag.PoNumber}";
+    ViewData["Title"] = $"Receive Goods - {ViewBag.PoNumber}";
     int poId = (int)ViewBag.PoId;
 }
 

src/PowderCoating.Web/Views/SetupWizard/Step1.cshtml

@@ -1,7 +1,7 @@
-@using PowderCoating.Application.DTOs.Wizard
+@using PowderCoating.Application.DTOs.Wizard
 @model WizardStep1Dto
 @{
-    ViewData["Title"] = "Setup Wizard — Company Profile";
+    ViewData["Title"] = "Setup Wizard - Company Profile";
     var progress = ViewBag.Progress as WizardProgressDto ?? new WizardProgressDto();
     int step = ViewBag.Step as int? ?? 1;
 }

src/PowderCoating.Web/Views/SetupWizard/Step10.cshtml

@@ -1,7 +1,7 @@
-@using PowderCoating.Application.DTOs.Wizard
+@using PowderCoating.Application.DTOs.Wizard
 @model WizardStep9Dto
 @{
-    ViewData["Title"] = "Setup Wizard — Team Members";
+    ViewData["Title"] = "Setup Wizard - Team Members";
     var progress = ViewBag.Progress as WizardProgressDto ?? new WizardProgressDto();
     int step = ViewBag.Step as int? ?? 10;
 }

src/PowderCoating.Web/Views/SetupWizard/Step11.cshtml

@@ -1,7 +1,7 @@
-@using PowderCoating.Application.DTOs.Wizard
+@using PowderCoating.Application.DTOs.Wizard
 @model WizardStep6Dto
 @{
-    ViewData["Title"] = "Setup Wizard — Chart of Accounts";
+    ViewData["Title"] = "Setup Wizard - Chart of Accounts";
     var progress = ViewBag.Progress as WizardProgressDto ?? new WizardProgressDto();
     int step = ViewBag.Step as int? ?? 11;
 }

src/PowderCoating.Web/Views/SetupWizard/Step12.cshtml

@@ -1,7 +1,7 @@
-@using PowderCoating.Application.DTOs.Wizard
+@using PowderCoating.Application.DTOs.Wizard
 @model WizardStep10Dto
 @{
-    ViewData["Title"] = "Setup Wizard — Vendors & Suppliers";
+    ViewData["Title"] = "Setup Wizard - Vendors & Suppliers";
     var progress = ViewBag.Progress as WizardProgressDto ?? new WizardProgressDto();
     int step = ViewBag.Step as int? ?? 12;
 }

src/PowderCoating.Web/Views/SetupWizard/Step13.cshtml

@@ -1,7 +1,7 @@
-@using PowderCoating.Application.DTOs.Wizard
+@using PowderCoating.Application.DTOs.Wizard
 @model WizardStep8Dto
 @{
-    ViewData["Title"] = "Setup Wizard — Inventory / Powder Colors";
+    ViewData["Title"] = "Setup Wizard - Inventory / Powder Colors";
     var progress = ViewBag.Progress as WizardProgressDto ?? new WizardProgressDto();
     int step = ViewBag.Step as int? ?? 13;
 }

src/PowderCoating.Web/Views/SetupWizard/Step14.cshtml

@@ -1,7 +1,7 @@
-@using PowderCoating.Application.DTOs.Wizard
+@using PowderCoating.Application.DTOs.Wizard
 @model WizardOvensStepDto
 @{
-    ViewData["Title"] = "Setup Wizard — Equipment & Ovens";
+    ViewData["Title"] = "Setup Wizard - Equipment & Ovens";
     var progress = ViewBag.Progress as WizardProgressDto ?? new WizardProgressDto();
     int step = ViewBag.Step as int? ?? 14;
 }

src/PowderCoating.Web/Views/SetupWizard/Step15.cshtml

@@ -1,7 +1,7 @@
-@using PowderCoating.Application.DTOs.Wizard
+@using PowderCoating.Application.DTOs.Wizard
 @model WizardPricingTiersStepDto
 @{
-    ViewData["Title"] = "Setup Wizard — Pricing Tiers";
+    ViewData["Title"] = "Setup Wizard - Pricing Tiers";
     var progress = ViewBag.Progress as WizardProgressDto ?? new WizardProgressDto();
     int step = ViewBag.Step as int? ?? 15;
 }

src/PowderCoating.Web/Views/SetupWizard/Step16.cshtml

@@ -1,7 +1,7 @@
-@using PowderCoating.Application.DTOs.Wizard
+@using PowderCoating.Application.DTOs.Wizard
 @model WizardCatalogStepDto
 @{
-    ViewData["Title"] = "Setup Wizard — Service Catalog";
+    ViewData["Title"] = "Setup Wizard - Service Catalog";
     var progress = ViewBag.Progress as WizardProgressDto ?? new WizardProgressDto();
     int step = ViewBag.Step as int? ?? 16;
 }

src/PowderCoating.Web/Views/SetupWizard/Step17.cshtml

@@ -1,7 +1,7 @@
-@using PowderCoating.Application.DTOs.Wizard
+@using PowderCoating.Application.DTOs.Wizard
 @model WizardStep7Dto
 @{
-    ViewData["Title"] = "Setup Wizard — Notifications";
+    ViewData["Title"] = "Setup Wizard - Notifications";
     var progress = ViewBag.Progress as WizardProgressDto ?? new WizardProgressDto();
     int step = ViewBag.Step as int? ?? 17;
 }

src/PowderCoating.Web/Views/SetupWizard/Step18.cshtml

@@ -1,7 +1,7 @@
-@using PowderCoating.Application.DTOs.Wizard
+@using PowderCoating.Application.DTOs.Wizard
 @model WizardStep9Dto
 @{
-    ViewData["Title"] = "Setup Wizard — Team Members";
+    ViewData["Title"] = "Setup Wizard - Team Members";
     var progress = ViewBag.Progress as WizardProgressDto ?? new WizardProgressDto();
     int step = ViewBag.Step as int? ?? 18;
 }

src/PowderCoating.Web/Views/SetupWizard/Step2.cshtml

@@ -1,7 +1,7 @@
-@using PowderCoating.Application.DTOs.Wizard
+@using PowderCoating.Application.DTOs.Wizard
 @model WizardStep2QbDto
 @{
-    ViewData["Title"] = "Setup Wizard — QuickBooks Migration";
+    ViewData["Title"] = "Setup Wizard - QuickBooks Migration";
     var progress = ViewBag.Progress as WizardProgressDto ?? new WizardProgressDto();
     int step = ViewBag.Step as int? ?? 2;
 }

src/PowderCoating.Web/Views/SetupWizard/Step3.cshtml

@@ -1,8 +1,8 @@
-@using PowderCoating.Application.DTOs.Wizard
+@using PowderCoating.Application.DTOs.Wizard
 @using PowderCoating.Core.Enums
 @model WizardStep2Dto
 @{
-    ViewData["Title"] = "Setup Wizard — Operating Costs";
+    ViewData["Title"] = "Setup Wizard - Operating Costs";
     var progress = ViewBag.Progress as WizardProgressDto ?? new WizardProgressDto();
     int step = ViewBag.Step as int? ?? 3;
 }

src/PowderCoating.Web/Views/SetupWizard/Step4.cshtml

@@ -1,7 +1,7 @@
-@using PowderCoating.Application.DTOs.Wizard
+@using PowderCoating.Application.DTOs.Wizard
 @model WizardOvensStepDto
 @{
-    ViewData["Title"] = "Setup Wizard — Shop Equipment";
+    ViewData["Title"] = "Setup Wizard - Shop Equipment";
     var progress = ViewBag.Progress as WizardProgressDto ?? new WizardProgressDto();
     int step = ViewBag.Step as int? ?? 4;
 }

src/PowderCoating.Web/Views/SetupWizard/Step5.cshtml

@@ -1,7 +1,7 @@
-@using PowderCoating.Application.DTOs.Wizard
+@using PowderCoating.Application.DTOs.Wizard
 @model WizardStep3Dto
 @{
-    ViewData["Title"] = "Setup Wizard — Document Numbering";
+    ViewData["Title"] = "Setup Wizard - Document Numbering";
     var progress = ViewBag.Progress as WizardProgressDto ?? new WizardProgressDto();
     int step = ViewBag.Step as int? ?? 5;
 }

src/PowderCoating.Web/Views/SetupWizard/Step6.cshtml

@@ -1,7 +1,7 @@
-@using PowderCoating.Application.DTOs.Wizard
+@using PowderCoating.Application.DTOs.Wizard
 @model WizardStep5Dto
 @{
-    ViewData["Title"] = "Setup Wizard — Job Settings";
+    ViewData["Title"] = "Setup Wizard - Job Settings";
     var progress = ViewBag.Progress as WizardProgressDto ?? new WizardProgressDto();
     int step = ViewBag.Step as int? ?? 6;
 }

src/PowderCoating.Web/Views/SetupWizard/Step7.cshtml

@@ -1,7 +1,7 @@
-@using PowderCoating.Application.DTOs.Wizard
+@using PowderCoating.Application.DTOs.Wizard
 @model WizardStep4Dto
 @{
-    ViewData["Title"] = "Setup Wizard — Payment Terms";
+    ViewData["Title"] = "Setup Wizard - Payment Terms";
     var progress = ViewBag.Progress as WizardProgressDto ?? new WizardProgressDto();
     int step = ViewBag.Step as int? ?? 7;
 }

src/PowderCoating.Web/Views/SetupWizard/Step8.cshtml

@@ -1,7 +1,7 @@
-@using PowderCoating.Application.DTOs.Wizard
+@using PowderCoating.Application.DTOs.Wizard
 @model WizardPricingTiersStepDto
 @{
-    ViewData["Title"] = "Setup Wizard — Pricing Tiers";
+    ViewData["Title"] = "Setup Wizard - Pricing Tiers";
     var progress = ViewBag.Progress as WizardProgressDto ?? new WizardProgressDto();
     int step = ViewBag.Step as int? ?? 8;
 }

src/PowderCoating.Web/Views/SetupWizard/Step9.cshtml

@@ -1,7 +1,7 @@
-@using PowderCoating.Application.DTOs.Wizard
+@using PowderCoating.Application.DTOs.Wizard
 @model WizardStep7Dto
 @{
-    ViewData["Title"] = "Setup Wizard — Notifications";
+    ViewData["Title"] = "Setup Wizard - Notifications";
     var progress = ViewBag.Progress as WizardProgressDto ?? new WizardProgressDto();
     int step = ViewBag.Step as int? ?? 5;
 }

src/PowderCoating.Web/Views/Shared/_KioskLayout.cshtml

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html>
 <html lang="en" data-bs-theme="light">
 <head>
     <meta charset="utf-8" />

src/PowderCoating.Web/Views/StripeEvents/Details.cshtml

@@ -1,7 +1,7 @@
-@using PowderCoating.Core.Entities
+@using PowderCoating.Core.Entities
 @model StripeWebhookEvent
 @{
-    ViewData["Title"] = $"Webhook Event – {Model.EventId}";
+    ViewData["Title"] = $"Webhook Event - {Model.EventId}";
     var statusClass = Model.Status switch
     {
         StripeWebhookEventStatus.Processed => "success",

src/PowderCoating.Web/Views/SubscriptionManagement/Manage.cshtml

@@ -2,7 +2,7 @@
 @using PowderCoating.Core.Enums
 @model Company
 @{
-    ViewData["Title"] = $"Manage – {Model.CompanyName}";
+    ViewData["Title"] = $"Manage - {Model.CompanyName}";
     var planConfigs = (dynamic)ViewBag.PlanConfigs;
 
     string PlanName(int plan)

src/PowderCoating.Web/Views/Vendors/Statement.cshtml

@@ -1,6 +1,6 @@
-@model PowderCoating.Application.DTOs.Accounting.VendorStatementDto
+@model PowderCoating.Application.DTOs.Accounting.VendorStatementDto
 @{
-    ViewData["Title"] = $"Statement – {Model.VendorName}";
+    ViewData["Title"] = $"Statement - {Model.VendorName}";
 }
 
 <div class="d-flex justify-content-between align-items-start mb-4 flex-wrap gap-2">