spouliot/PowderCoatingLogix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix inline edit not updating pricing breakdown on Job Details

Browse Source 
Jobs/PatchItem now returns the full breakdown (itemsSubtotal,
subtotalBeforeDiscount, subtotalAfterDiscount, taxAmount) so all rows
in the pricing card update live without a page refresh.

Added data-pb attributes to the matching spans in the pricing panel.
Updated window.inlineItemEdit.totals config for jobs to map each
response key to its DOM selector.

updateTotals in inline-item-edit.js is now fully generic — cfg.totals
keys must match server response property names directly, eliminating
the old hardcoded tax/taxAmount and balance/balanceDue mismatches.
Updated Quote and Invoice configs accordingly (tax→taxAmount,
balance→balanceDue).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Scott Pouliot
2026-05-20 22:58:26 -04:00
parent 30c644a8ec
commit eb13283e76
5 changed files with 31 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/PowderCoating.Web/Controllers/JobsController.cs
+11 -2
View File
@@ -4264,9 +4264,18 @@ public class JobsController : Controller
await _unitOfWork.Jobs.UpdateAsync(job);
await _unitOfWork.CompleteAsync();
// Deserialize again after possible re-serialization to get final values
QuotePricingBreakdownDto? pbFinal = null;
if (!string.IsNullOrEmpty(job.PricingBreakdownJson))
pbFinal = JsonSerializer.Deserialize<QuotePricingBreakdownDto>(job.PricingBreakdownJson);
return Json(new {
lineTotal = item.TotalPrice,
finalPrice = job.FinalPrice
lineTotal = item.TotalPrice,
finalPrice = job.FinalPrice,
itemsSubtotal = pbFinal?.ItemsSubtotal,
subtotalBeforeDiscount = pbFinal?.SubtotalBeforeDiscount,
subtotalAfterDiscount = pbFinal?.SubtotalAfterDiscount,
taxAmount = pbFinal?.TaxAmount
});
}
}
src/PowderCoating.Web/Views/Invoices/Details.cshtml
+2 -2
View File
@@ -1458,9 +1458,9 @@
canEdit: @Json.Serialize(canEdit),
totals: {
subtotal: '#inv-subtotal',
tax: '#inv-tax',
taxAmount: '#inv-tax',
total: '#inv-total',
balance: '#inv-balance'
balanceDue: '#inv-balance'
}
};
</script>
src/PowderCoating.Web/Views/Jobs/Details.cshtml
+9 -5
View File
@@ -1611,7 +1611,7 @@
}
<div class="d-flex justify-content-between small fw-semibold border-top pt-1 mt-1">
<span>Items subtotal</span>
<span>@jobPb.ItemsSubtotal.ToString("C")</span>
<span data-pb="itemsSubtotal">@jobPb.ItemsSubtotal.ToString("C")</span>
</div>
</div>
@@ -1660,7 +1660,7 @@
</div>
<div class="d-flex justify-content-between small mb-1">
<span class="text-muted">Subtotal</span>
<span>@jobPb.SubtotalBeforeDiscount.ToString("C")</span>
<span data-pb="subtotalBeforeDiscount">@jobPb.SubtotalBeforeDiscount.ToString("C")</span>
</div>
@if (jobPb.DiscountAmount > 0)
{
@@ -1670,7 +1670,7 @@
</div>
<div class="d-flex justify-content-between small mb-1">
<span class="text-muted">After discount</span>
<span>@jobPb.SubtotalAfterDiscount.ToString("C")</span>
<span data-pb="subtotalAfterDiscount">@jobPb.SubtotalAfterDiscount.ToString("C")</span>
</div>
}
@if (jobPb.RushFee > 0)
@@ -1684,7 +1684,7 @@
{
<div class="d-flex justify-content-between small mb-1">
<span class="text-muted">Tax (@jobPb.TaxPercent.ToString("G29")%)</span>
<span>@jobPb.TaxAmount.ToString("C")</span>
<span data-pb="taxAmount">@jobPb.TaxAmount.ToString("C")</span>
</div>
}
<div class="d-flex justify-content-between fw-bold border-top pt-2 mt-1">
@@ -2422,7 +2422,11 @@
patchUrl: '@Url.Action("PatchItem", "Jobs")',
canEdit: true,
totals: {
finalPrice: '.job-final-price-display'
itemsSubtotal: '[data-pb="itemsSubtotal"]',
subtotalBeforeDiscount: '[data-pb="subtotalBeforeDiscount"]',
subtotalAfterDiscount: '[data-pb="subtotalAfterDiscount"]',
taxAmount: '[data-pb="taxAmount"]',
finalPrice: '.job-final-price-display'
}
};
</script>
src/PowderCoating.Web/Views/Quotes/Details.cshtml
+3 -3
View File
@@ -2268,9 +2268,9 @@
patchUrl: '@Url.Action("PatchItem", "Quotes")',
canEdit: true,
totals: {
subtotal: '#quote-subtotal',
tax: '#quote-tax',
total: '#quote-total'
subtotal: '#quote-subtotal',
taxAmount: '#quote-tax',
total: '#quote-total'
}
};
</script>
src/PowderCoating.Web/wwwroot/js/inline-item-edit.js
+6 -9
View File
@@ -24,17 +24,14 @@
setTimeout(() => el.remove(), 4000);
}
// cfg.totals maps response-property-name → CSS selector.
// Each key must exactly match a property returned by the server's PatchItem action.
function updateTotals(cfg, data) {
const t = cfg.totals || {};
[
[t.subtotal, data.subtotal],
[t.tax, data.taxAmount],
[t.total, data.total],
[t.finalPrice, data.finalPrice],
[t.balance, data.balanceDue],
].forEach(([sel, val]) => {
if (sel && val !== undefined && val !== null) {
document.querySelectorAll(sel).forEach(el => { el.textContent = fmt(val); });
Object.entries(t).forEach(([key, selector]) => {
const val = data[key];
if (selector && val !== undefined && val !== null) {
document.querySelectorAll(selector).forEach(el => { el.textContent = fmt(val); });
}
});
}